Skip to content

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented Apr 1, 2021

…PMIC data entry panels.

  • Added a new db field "Instance" to extscheduler.Resources to solve the container issue.

Rationale

Related Pull Requests

Changes

…PMIC data entry panels.

- Added a new db field "Instance" to extscheduler.Resources to solve the container issue.
@kollil kollil changed the title - Added code to hide the "ChargeType" and "CreditTo" fields from all … Added changes to PMIC project Apr 1, 2021
@kollil
Copy link
Collaborator Author

kollil commented Apr 5, 2021

Josh, Please approve this change so I can put it on uat and production. Its tested on prime20test.

Thanks
Lakshmi

@@ -0,0 +1 @@
ALTER TABLE extscheduler.Resources ADD Instance varchar(50); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this new column to the extscheduler.xml file too. This will keep our automated tests passing on TeamCity.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field "Instance" is added to the xml file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this failure is because we're doing an upgrade for a server that TeamCity uses:

https://www.labkey.org/Premium/announcements-thread.view?rowId=21295

Your build snuck in before the cutoff, but wasn't done in time to avoid the error. The maintenance should be done soon, and we can re-queue an installer build then.

@kollil
Copy link
Collaborator Author

kollil commented Apr 7, 2021

Josh, Could you please approve the changes, I have tested the changes on prime20test and they are working fine.

Thanks
Lakshmi

@kollil kollil merged commit beff13c into release20.11-SNAPSHOT Apr 7, 2021
@kollil kollil deleted the 20.11_fb_PMIC_changes branch April 7, 2021 16:48
@kollil kollil requested a review from jonesgaohsu April 7, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants