-
Notifications
You must be signed in to change notification settings - Fork 3
Added changes to PMIC project #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…PMIC data entry panels. - Added a new db field "Instance" to extscheduler.Resources to solve the container issue.
|
Josh, Please approve this change so I can put it on uat and production. Its tested on prime20test. Thanks |
| @@ -0,0 +1 @@ | |||
| ALTER TABLE extscheduler.Resources ADD Instance varchar(50); No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this new column to the extscheduler.xml file too. This will keep our automated tests passing on TeamCity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field "Instance" is added to the xml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Build #144 failed with a gradle exception. Did I miss anything?
https://teamcity.labkey.org/buildConfiguration/LabKey_2011Release_External_Onprc_OnprcInstaller?mode=builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this failure is because we're doing an upgrade for a server that TeamCity uses:
https://www.labkey.org/Premium/announcements-thread.view?rowId=21295
Your build snuck in before the cutoff, but wasn't done in time to avoid the error. The maintenance should be done soon, and we can re-queue an installer build then.
…cation field names.
|
Josh, Could you please approve the changes, I have tested the changes on prime20test and they are working fine. Thanks |
…PMIC data entry panels.
Rationale
Related Pull Requests
Changes