Skip to content

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented Apr 7, 2021

Rationale

A new "notes" alert is added to the Behavior notifications.

@kollil kollil requested a review from labkey-jeckels April 7, 2021 23:40
@kollil
Copy link
Collaborator Author

kollil commented Apr 7, 2021

Josh, I added only one file BehaviorNotification.java file to this new fb. Don't know how the previous commits got added to this pull. Please remove them.

Thanks
lakshmi

@labkey-jeckels labkey-jeckels changed the base branch from develop to release20.11-SNAPSHOT April 7, 2021 23:58
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason so many files were showing up was because you hadn't set the target branch to release20.11-SNAPSHOT. It was still the default, which is "develop", which doesn't yet have all of the other changes you've merged into release20.11-SNAPSHOT.

Anytime you have unexpected files showing in the list in the pull request it's a good idea to double-check the source and target branches.

@kollil
Copy link
Collaborator Author

kollil commented Apr 8, 2021

Yes, Josh, you are right. I got confused as it showed me "Compare & Pull Request" button instead of just "Pull request" button. I did something to edit that as I didn't have anything to compare.
I will be careful next time.

@kollil kollil merged commit c2ed328 into release20.11-SNAPSHOT Apr 12, 2021
@kollil kollil deleted the 20.11_fb_Behavior_Alert branch April 12, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants