Skip to content

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented May 4, 2021

Rationale

SLA usage query fix

Related Pull Requests

Changes

@kollil kollil requested a review from labkey-jeckels May 4, 2021 21:03
@kollil
Copy link
Collaborator Author

kollil commented May 4, 2021

Josh, Please approve to merge this change. I have tested the fix in Prime20uat and it's working great.

@labkey-jeckels labkey-jeckels changed the base branch from develop to release20.11-SNAPSHOT May 4, 2021 22:54
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to do a quick sanity check on the "Files changed" tab when you create a pull request. This one was reporting 90+ files that were changed, because it was targeting the "develop" branch instead of "release20.11-SNAPSHOT". I changed it and it's now showing a single edited file, which looks fine.

@kollil kollil merged commit bef6ed6 into release20.11-SNAPSHOT May 4, 2021
@kollil kollil deleted the 20.11_fb_SLAUsageFix branch May 4, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants