PMIC service req form flow changes. #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
May 11, 2021
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
This looks fine if you want to proceed as-is, but I know you're interested in splitting out the query so that you can avoid having two Create Task menu items
…ne preventive care alerts.
Collaborator
Author
|
Josh, After I merged the changes, I see an error on team city for the build #224. That update is also included in the final merge. |
Contributor
|
Hi @kollil , Josh is out this week, think that error is not related to any change. After getting merged, there is a new build running on the default branch https://teamcity.labkey.org/buildConfiguration/LabKey_2011Release_External_Onprc_OnprcInstaller?branch=%3Cdefault%3E&buildTypeTab=overview&mode=builds |
Collaborator
Author
|
Thank you Ankur for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This update contains the PMIC flow after the taskid is created. A new label is created for PMIC task to "More actions" list.