Skip to content

Conversation

@jonesgaohsu
Copy link
Collaborator

Rationale

Update of Rate Sheets Labels

Related Pull Requests

Changes

Update of All NIH Public Rate Sheets


<column columnName="year6">
<columnTitle>YR67: 5/1/26 to 4/30/27</columnTitle>
<columnTitle>YR68: 5/1/26=7 to 4/30/28</columnTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same typo here.

Suggested change
<columnTitle>YR68: 5/1/26=7 to 4/30/28</columnTitle>
<columnTitle>YR68: 5/1/27 to 4/30/28</columnTitle>

@jonesgaohsu
Copy link
Collaborator Author

Code cleaned up and ready for review

@labkey-jeckels
Copy link
Contributor

@jonesgaohsu you fixed the typo and pushed in onprc_billingpublic/resources/queries/onprc_billing_public/NIHRateSheet.query.xml but the other files haven't been corrected yet

@jonesgaohsu
Copy link
Collaborator Author

Josh is this ready to be merged or am I missing a step

@labkey-ankurj
Copy link
Contributor

Hi @jonesgaohsu, Josh is out this week, seems like there are suggestions to these files as well from Josh, that are pending corrections-
onprc_billingpublic/resources/queries/onprc_billing_public/NIHIndustryRates.query.xml
onprc_billingpublic/resources/queries/onprc_billing_public/NIHRateConfig.query.xml
onprc_billingpublic/resources/queries/onprc_billing_public/NIHRates_ReducedFA.query.xml

@jonesgaohsu jonesgaohsu requested a review from labkey-bpatel May 17, 2021 20:01
jonesgaohsu and others added 3 commits May 17, 2021 13:18
…RateConfig.query.xml

Co-authored-by: Josh Eckels <jeckels@labkey.com>
…Rates_ReducedFA.query.xml

Co-authored-by: Josh Eckels <jeckels@labkey.com>
…IndustryRates.query.xml

Co-authored-by: Josh Eckels <jeckels@labkey.com>
Copy link
Collaborator Author

@jonesgaohsu jonesgaohsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I have gotten all of them thought I had made these earlier

@jonesgaohsu
Copy link
Collaborator Author

Ability to squash and merge this item appears to be locked

@labkey-keith labkey-keith dismissed labkey-jeckels’s stale review May 19, 2021 19:10

Ankur has reviewed the changes

@labkey-keith
Copy link

Hi Gary, I think that you should be able to squash and merge now.

@jonesgaohsu jonesgaohsu merged commit 4125073 into release20.11-SNAPSHOT May 20, 2021
@jonesgaohsu jonesgaohsu deleted the 20.11_fb_UpdateRateSheetXML branch May 20, 2021 13:33
@jonesgaohsu
Copy link
Collaborator Author

Item was squashed and merged into default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants