Skip to content

Conversation

@Ohsudev
Copy link
Collaborator

@Ohsudev Ohsudev commented Jun 2, 2021

… inadvertently removed from the web page.

Rationale

Related Pull Requests

Changes

Restored the Weights by Monkey Id from the Printable reports that was inadvertently removed from the web page.

@Ohsudev Ohsudev requested review from kollil and labkey-jeckels June 2, 2021 00:38
@labkey-jeckels
Copy link
Contributor

@Ohsudev your change looks fine. You'll see what I pushed a separate change to get the automated tests passing again - they've been broken for a little while from some unrelated changes.

Going forward, I'm going to be strict on making sure that PRs don't introduce new failures. @keith-labkey let's put this on the agenda for our next weekly call.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an intermittent test failure during the most recent run, but the failure related to missing columns in the PMIC_CTImagingData dataset is resolved. Please merge at your convenience.

@labkey-jeckels
Copy link
Contributor

@Ohsudev Is this ready to merge? We'd like to get the test fix in before we do the 20.11->21.3 merge that we discussed on Tuesday's all.

@labkey-tchad This fixes the failure that you noticed in 20.11.

@Ohsudev
Copy link
Collaborator Author

Ohsudev commented Jun 4, 2021 via email

@labkey-jeckels labkey-jeckels merged commit f309cb5 into release20.11-SNAPSHOT Jun 4, 2021
@labkey-jeckels labkey-jeckels deleted the 20.11_fb_WeightSheetByMonkeyIDReport branch June 4, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants