Skip to content

Conversation

@kollil
Copy link
Collaborator

@kollil kollil commented May 24, 2022

Fixed the query to display the allowable SLA data on the protocol display page.

@kollil kollil requested a review from Ohsudev May 24, 2022 22:56
@labkey-keith
Copy link

@kollil I notice that the tests are not passing on this feature branch. Please be sure to look at these before considering merging this. Please reach out if you have questions about the cause of the error.

@kollil
Copy link
Collaborator Author

kollil commented May 25, 2022

@kollil I notice that the tests are not passing on this feature branch. Please be sure to look at these before considering merging this. Please reach out if you have questions about the cause of the error.

@keith-labkey, I have noticed the ehrsla.xml file got included into this fb, I thought this was deleted from the 22.3 final merge. I didn't dig deeper as I am busy with the other sla issues. Went ahead and deleted this file as it is irrelevant and updated the fb. Hopefully it gets deleted from the master after its deployed.

@kollil kollil merged commit 03dbeef into release22.3-SNAPSHOT May 26, 2022
@kollil kollil deleted the 22.3_fb_allowableSLAFix branch May 26, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants