Revert subtle CreateContainerAction behavior change
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
TrialShare tests pass with this change: https://teamcity.labkey.org/viewLog.html?buildId=976384 |
labkey-tchad
changed the title
CreateContainerAction as untouched as possibleCreateContainerAction behavior change
labkey-jeckels
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The previous change caused new subfolders to not inherit active modules from their parent in some cases. This is causing some
trialsharetests to fail.Related Pull Requests
Initial breaking change: #1058
First fix attempt: #1073
Changes
CreateContainerActionbehavior exactly unless theensureModulesproperty is provided