Skip to content

Conversation

@labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Jul 7, 2021

Rationale

Issue 41705 outlines the desire to have a clearSelected parameter made available from query-getSelected.api. This is the endpoint that backs LABKEY.DataRegion.getSelected(). For more in-depth discussion see LabKey/LabDevKitModules#55 (comment).

Related Pull Requests

Changes

  • Support clearSelected for both the form-based and viewContext-based variants of DataRegionSelection.getSelected().
  • Add clearSelected parameter support into client-side DataRegion.getSelected() wrapper.
  • Add a regression test is run as a part of DataRegionTest.
  • Refactor DataRegionSelection by removing redundant logic, streamlining null handling, and the following:
    • Centralize logic for computing session key in getSessionAttributeKey().
    • getSet() is now @NotNull safe as it will always provide a non-null value.
    • Centralize logic for fetching a QueryView from a QueryForm.
    • Remove redundant logic from setSelectionForAll that is found in getDataRegionContext().
    • Coalesce logic for handling fetching a selection from a ResultSetRowMapFactory into createSelectionList().
  • Update client-side Data Region selection API wrappers always POST as they may mutate server state. Additionally, use payload for parameters rather than URL parameters.

@labkey-nicka labkey-nicka merged commit 01261b2 into develop Jul 7, 2021
@labkey-nicka labkey-nicka deleted the fb_fix_41705 branch July 7, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants