41705: Support clearing selection from getSelected() #2432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 41705 outlines the desire to have a
clearSelectedparameter made available fromquery-getSelected.api. This is the endpoint that backsLABKEY.DataRegion.getSelected(). For more in-depth discussion see LabKey/LabDevKitModules#55 (comment).Related Pull Requests
Changes
clearSelectedfor both the form-based and viewContext-based variants ofDataRegionSelection.getSelected().clearSelectedparameter support into client-sideDataRegion.getSelected()wrapper.DataRegionTest.DataRegionSelectionby removing redundant logic, streamlining null handling, and the following:getSessionAttributeKey().getSet()is now@NotNullsafe as it will always provide a non-null value.QueryViewfrom aQueryForm.setSelectionForAllthat is found ingetDataRegionContext().ResultSetRowMapFactoryintocreateSelectionList().POSTas they may mutate server state. Additionally, use payload for parameters rather than URL parameters.