Introduce WritablePropertyMap #5893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently,
PropertyMapis a mutable Map that also offers delete(), save(), etc., even for property maps that should be read-only. This is poor practice and has led to caching issues and bugs like https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=48993A better approach is to make PropertyMap read-only (immutable) and introduce
WritablePropertyMap, which allows map mutation (e.g., put(), remove()) and implements delete(), save(), etc. Property maps are used in many repositories, so this initial PR introduces the new class without yet splitting out our persistence methods. Once all repos are converted to use the new class we'll move those methods.