Skip to content

PropertyMaps can no longer be saved or deleted #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-adam merged 2 commits into from
Oct 8, 2024
Merged

PropertyMaps can no longer be saved or deleted #5909

labkey-adam merged 2 commits into from
Oct 8, 2024
+83 −121

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Oct 2, 2024 •
edited
Loading

Rationale

Now that we've introduced WritablePropertyMap and used it in every code path that calls delete() or save(), move those persistence methods from PropertyMap to WritablePropertyMap. Eliminate setLock() and checkLock() since PropertyMap is immutable. Simplify initialization of _modified.

Related Pull Requests

@labkey-adam labkey-adam merged commit 99fe48d into develop Oct 8, 2024
@labkey-adam labkey-adam deleted the fb_writable_property_maps branch October 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-matthewb labkey-matthewb labkey-matthewb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-adam @labkey-matthewb