-
Notifications
You must be signed in to change notification settings - Fork 7
Junit test for timestamps on French SQL Server #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bigiron/src/org/labkey/bigiron/mssql/MicrosoftSqlServer2016Dialect.java
Outdated
Show resolved
Hide resolved
|
Verifying on |
labkey-tchad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be causing a connection leak.
|
Yup, got a run with mem tracker stacktraces enabled: |
Yep, I see that. Will track it down... |
|
Note that the one BVT test run in red below passed in a subsequent run: https://teamcity.labkey.org/buildConfiguration/LabKey_247Release_Community_BvtBSqlserver/3251902?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false |
labkey-tchad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is making me very paranoid about anonymous classes.
Rationale
Related PR fixes issues with timestamps used in compare clauses on SQL Server. This adds a junit test for the fix.
Related Pull Requests
Changes
Connectionto aTableSelector