Skip to content

Handle unusual query encoding in link href #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 1 commit into from
Dec 9, 2024
Merged

Handle unusual query encoding in link href #6137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions study/test/src/org/labkey/test/tests/study/StudyMergeParticipantsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ protected void doVerifySteps()

log("Check url's to are correctly constructed");
final String url = WebTestHelper.buildRelativeUrl("study", PROJECT_NAME + "/" + FOLDER_NAME, "dataset",
Maps.of("datasetId", 5018,
"Dataset.ParticipantId~in", PTID_NO_ALIAS + ";" + PTID_NEW_2));
Maps.of("datasetId", 5018, "Dataset.ParticipantId~in", PTID_NO_ALIAS + ";" + PTID_NEW_2))
.replace("%7E", "~"); // '~' isn't encoded in href
Copy link
Contributor

@labkey-chrisj labkey-chrisj Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this substitution generalizable for other use cases? Asking to prompt the question whether this should be done in a helper vs. in test code

Copy link
Member Author

@labkey-tchad labkey-tchad Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't count on it. There are a lot of "valid" encodings and I doubt we're consistent on the product side. We should probably avoid finding elements by href attribute like this. It would be preferable to grab the link by some other means and decode it.

assertElementPresent(Locator.linkWithHref(url));

log("Resolve conflicts and check for correct row retention");
Expand All @@ -148,8 +148,8 @@ protected void doVerifySteps()
clickTab(SUBJECT_NOUN_PLURAL);
waitAndClick(Locator.linkWithText(PTID_NEW_2));
waitForElement(Locator.tag("th").containing("5008: Demographics"));
assertElementPresent(Locator.tag("td").containing("Start Date").append("/following-sibling::td['2008-04-27']")); //value from oldId demographic row
assertElementPresent(Locator.tag("td").containing("Genetic Consent").append("/following-sibling::td['false']")); //value from newId consent row
assertElementPresent(Locator.tag("td").containing("Start Date").followingSibling("td").withText("2008-04-27")); //value from oldId demographic row
assertElementPresent(Locator.tag("td").containing("Genetic Consent").followingSibling("td").withText("false")); //value from newId consent row
}

private void configureAliases()
Expand Down
Loading