Skip to content

Implement TransactionCache.getKeys() #6507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-adam merged 3 commits into from
Apr 2, 2025
Merged

Implement TransactionCache.getKeys() #6507

labkey-adam merged 3 commits into from
Apr 2, 2025

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Mar 30, 2025 •
edited
Loading

Rationale

  • TransactionCache.getKeys() comes in handy for removeUsingFilter() and testing
  • Add more DatabaseCache junit tests
  • Repackage TransactionCache since DatabaseCache is its only user
  • Move BlockingDatabaseCache-specific inner classes into that class
  • Eliminate org.labkey.api.util.Filter in favor of Predicate
  • Eliminate SpecimenImportStrategy, factory, registration, enumeration, etc. -- this whole mess is now just an elaborate no-op
  • Address some warnings in MemberSet and SparseBitSet

@labkey-adam labkey-adam mentioned this pull request Mar 30, 2025
Merged
@labkey-adam labkey-adam merged commit 6a3b1e2 into develop Apr 2, 2025
7 checks passed
@labkey-adam labkey-adam deleted the fb_caching branch April 2, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-matthewb labkey-matthewb labkey-matthewb approved these changes

@labkey-jeckels labkey-jeckels Awaiting requested review from labkey-jeckels

@labkey-martyp labkey-martyp Awaiting requested review from labkey-martyp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-adam @labkey-matthewb