Skip to content

Simplify and expand use of LinkBuilder factory methods #6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-adam merged 1 commit into from
Apr 14, 2025
Merged

Simplify and expand use of LinkBuilder factory methods #6561

labkey-adam merged 1 commit into from
Apr 14, 2025

Conversation

@labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Apr 14, 2025 •
edited
Loading

Rationale

Using LinkBuilder factory methods simplifies the creation of links and provides consistency & clarity

  • Add LinkBuilder and JspBase factory methods for more common use cases
  • Migrate many uses to the appropriate factory method
  • Eliminate all uses of PageFlowUtil.link() methods
  • Eliminate most clearClasses() calls

This was referenced Apr 14, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@labkey-adam labkey-adam merged commit 6085f64 into develop Apr 14, 2025
18 checks passed
@labkey-adam labkey-adam deleted the fb_linkbuilder branch April 14, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-adam @labkey-jeckels