Skip to content

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Jun 17, 2025

Rationale

LuminexPositivityTest and LuminexAsyncImportTest started failing recently in develop. Turns out the runProperties.tsv file for the transform script was writing null values as "null" instead of "". This was related to the StringUtils.defaultString() - Objects.toString() change from this PR #6742

Related Pull Requests

Changes

  • set nullDefault param as "" for Object.toString()

…eing written to runProperties.tsv as "null" instead of ""
@cnathe
Copy link
Contributor Author

cnathe commented Jun 17, 2025

@josheckels do you think any of the other cases that changed from StringUtils.defaultString() to Objects.toString() need to add this nullDefault parameter as "" to match previous behavior?

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cory. I thought I had tracked down all of these single-argument calls to toString() in the refactor to avoid this problem, but it looks like this snuck through. I double-checked for other examples in my big refactor commit and couldn't find any.

@cnathe cnathe merged commit b10c11a into develop Jun 17, 2025
13 checks passed
@cnathe cnathe deleted the fb_luminexRunPropNullFix branch June 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants