Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Aug 25, 2025

Rationale

We should support all column names in linked schemas. Even those with quotes in them.

Changes

  • Properly escape the quotes
  • Minor code cleanup

Tasks 📍

@labkey-jeckels labkey-jeckels requested review from a team and labkey-danield August 25, 2025 23:07
@labkey-jeckels
Copy link
Contributor Author

@labkey-danield think we should add a quote to one of the fields in your new test, or somewhere else? Fuzzing will hit it periodically, but should be simple to make sure we have consistent coverage.

LabKey/testAutomation#2645

@labkey-jeckels labkey-jeckels self-assigned this Aug 26, 2025
@labkey-jeckels labkey-jeckels merged commit 796c4a4 into release25.7-SNAPSHOT Aug 26, 2025
15 of 16 checks passed
@labkey-jeckels labkey-jeckels deleted the 25.7_fb_53784_linkedSchemaQuote branch August 26, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants