Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

Recent work on the search queue introduced a no-op implementation for the service. Thus, we don't need to check if it's null anymore.

Changes

  • Just use the available SearchService and let it do nothing if it chooses

Tasks 📍

  • Manual Testing - N/A
  • Needs Automation - N/A

Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many files here have whitespace changes on every line; I doubt that's what you want. Same thing happened to me a week ago... I don't know why. I created a new FB with the same patch and it produced the expected diff. 🤷

@labkey-jeckels
Copy link
Contributor Author

Many files here have whitespace changes on every line; I doubt that's what you want. Same thing happened to me a week ago... I don't know why. I created a new FB with the same patch and it produced the expected diff. 🤷

Probably a line ending thing, possibly OSX vs Windows. Did you push your FB to GitHub? I'm not seeing it. I can kill this PR and use your branch instead.

@labkey-adam
Copy link
Contributor

Many files here have whitespace changes on every line; I doubt that's what you want. Same thing happened to me a week ago... I don't know why. I created a new FB with the same patch and it produced the expected diff. 🤷

Probably a line ending thing, possibly OSX vs Windows. Did you push your FB to GitHub? I'm not seeing it. I can kill this PR and use your branch instead.

Sorry for confusion... I created a new FB for MY change last week, not this one. I don't think Windows was involved in your PR... you can see the line endings changes via the GitHub Web UI. I'm wondering if IntelliJ is changing line endings in certain cases.

@labkey-jeckels
Copy link
Contributor Author

Fresh PR where GitHub didn't mangle the line endings. Not sure why it behaved differently here. #7038

@labkey-jeckels labkey-jeckels deleted the fb_noOpSearchService branch September 15, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants