Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Nov 17, 2025

Rationale

We can continue to strengthen our protections against path traversal attacks and start phasing out deprecated and overloaded methods that take or return Files or Paths.

Changes

  • Eliminate some overloaded, deprecated versions of methods taking File or Path
  • Convert LocalDirectory and WorkDirectory to FileLike
  • Use FileLike more consistently for transform scripts

Tasks 📍

@labkey-jeckels labkey-jeckels self-assigned this Nov 17, 2025
@labkey-jeckels labkey-jeckels marked this pull request as ready for review November 24, 2025 17:20
Copy link
Contributor

@labkey-matthewb labkey-matthewb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot to go through line-by-line, but based on a first scan, I think we an merge. I love this deep cut against java.io.File.

@labkey-jeckels labkey-jeckels merged commit e74eb29 into develop Dec 3, 2025
11 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_fileLike3 branch December 3, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants