-
Notifications
You must be signed in to change notification settings - Fork 7
Issue 695: Add feature to allow unreferenced files to be deleted from apps #7320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release25.11-SNAPSHOT
Are you sure you want to change the base?
Conversation
| addColumn(Column.FileExtension); | ||
| addColumn(Column.WebDavUrl); | ||
| addColumn(Column.WebDavUrlRelative); | ||
| if (AppProps.getInstance().isOptionalFeatureEnabled(ExpSchema.SAMPLE_FILES_TABLE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is file related, it could / should instead be added to ExpFilesTable instead. Even though exp.files doesn't support container filtering, since Exp.UnreferencedSampleFiles does return data.container field, this can be used as the correct request context to query UnreferencedSampleFiles at its own container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we want to be able to link to a filtered set of files from the Unreferenced Sample Files page that should include the subfolder files, we're leaving this on the Data table. The Files table does not include subfolder files and does not have a column that can be filtered on to show only the sample files.
Rationale
Issue 695 - We generally do not remove files from the
@filesdirectory, so these files remain in the search index indefinitely. This causes some potential problems for some clients when users can discover, say, old SOPs that have subsequently been replaced and thus might follow incorrect procedures. Here we add the ability to delete the files that had been associated with sample file fields but are no longer referenced from the application and update theexp.datatable with a column that displays the reference counts for eachexp.datafile.Related Pull Requests
Changes
UnreferencedSampleFilesvirtual tableReferenceCountcolumn toexp.datatable.