Set pipeline config directory for embedded Tomcat #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Feb 15, 2024
| #context.oldEncryptionKey= | ||
| #context.requiredModules= | ||
| #context.pipelineConfig=/path/to/pipeline/config/dir | ||
| context.pipelineConfig=@@pathToServer@@/build/deploy/embedded/config |
Contributor
There was a problem hiding this comment.
Having a value for this property will cause the server to always use the "enterprise" pipeline (even if there's no JMS queue configured). I ultimately want to eliminate the non-enterprise implementation completely, but I'm not sure we're ready quite yet.
Can we easily make setting this property more conditional? If not, we can try this approach but will need to be looking more widely for pipeline problems, failure to shut down cleanly, etc.
Member
Author
There was a problem hiding this comment.
Sure. I can just have the task in sequenceAnalysis add this property, similar to how the premium module adds properties for ldapSync.
Member
Author
|
Going to make this change where it matters, instead of globally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some tests expect to put the pipeline config file in
build/deploy/embedded/config. The server needs to be configured to look there.Related Pull Requests
Changes
context.pipelineConfiginapplication.properties