Skip to content

Fix data region column name references #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 1 commit into from
Jul 2, 2025
Merged

Fix data region column name references #1090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/src/org/labkey/test/tests/targetedms/TargetedMSExperimentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,6 @@ protected void verifyMolecule()

//Look for Small Molecule Precursor List data region
drt = DataRegion(getDriver()).withName("small_mol_precursors_view").index(1).find();
assertEquals("PC aa C30:1", drt.getDataAsText(5, "Custom Ion Name"));
Copy link
Contributor

@labkey-danield labkey-danield Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???
Can you add a note in the comment/conversation part of this PR why this check is being removed?

Copy link
Member Author

@labkey-tchad labkey-tchad Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description to include my reasoning. (tldr; this assertion is redundant)

assertEquals("C38H74NO8P", drt.getDataAsText(5, "Ion Formula"));
assertEquals("703.9755", drt.getDataAsText(5, "Mass Average"));
assertEquals("703.5152", drt.getDataAsText(5, "Mass Monoisotopic"));
Expand Down