Skip to content

Declare api and implementation dependencies to align with code usages #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 5 commits into from
Sep 18, 2020
Merged

Declare api and implementation dependencies to align with code usages #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc74ec1
sqllite-jdbc no longer from :server:modules:platform:api
labkey-susanh Sep 7, 2020
a048ae4
Remove commons-math3 from api module dependencies
labkey-susanh Sep 7, 2020
f3f24a7
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 12, 2020
a0ec679
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 17, 2020
cd3b8f1
Align jars.txt with dependency declarations
labkey-susanh Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import org.labkey.gradle.util.BuildUtils;
dependencies
{
external 'com.google.protobuf:protobuf-java:3.12.2'
external "org.xerial:sqlite-jdbc:3.7.2"
external "org.apache.commons:commons-math3:${commonsMath3Version}"
external "org.jfree:jcommon:1.0.17"
implementation "org.apache.httpcomponents:httpmime:${httpmimeVersion}"
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: BuildUtils.getCommonAssayModuleProjectPath(project.gradle, "ms2"), depProjectConfig: "apiJarFile")
BuildUtils.addLabKeyDependency(project: project, config: "jspImplementation", depProjectPath: BuildUtils.getCommonAssayModuleProjectPath(project.gradle, "ms2"), depProjectConfig: "apiJarFile")
Expand Down
3 changes: 3 additions & 0 deletions resources/credits/jars.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{table}
Filename|Component|Version|Source|License|LabKey Dev|Purpose
commons-math3-3.6.1.jar|Commons Math|3.6.1|{link:Apache|http://commons.apache.org/math/}|{link:Apache 2.0|http://www.apache.org/licenses/LICENSE-2.0}||Lightweight, self-contained mathematics and statistics components
jcommon-1.0.17.jar|JFree Chart|1.0.17|{link:JFreeChart|http://www.jfree.org/jfreechart/}|{link:LGPL|http://www.gnu.org/licenses/lgpl.txt}||PNG encoder
protobuf-java-3.12.2.jar|Protocol Buffers|3.12.2|{link:Github Google|https://github.com/google/protobuf/releases}|{link:Custom|https://github.com/google/protobuf/blob/master/LICENSE}|nicksh|Binary data parsing
sqlite-jdbc-3.7.2.jar|SQLite JDBC Driver|3.7.2|{link:bitbucket.org|https://bitbucket.org/xerial/sqlite-jdbc/wiki/Home}|{link:Apache 2.0|http://www.apache.org/licenses/LICENSE-2.0}|vsharma|SQLite JDBC Driver
{table}