Don't encode parameters passed to WebTestHelper.buildUrl

src/org/labkey/test/util/APIContainerHelper.java

@@ -31,8 +31,6 @@
 
 import java.io.IOException;
 import java.net.SocketTimeoutException;
-import java.net.URLEncoder;
-import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -197,10 +195,10 @@ public void renameFolder(String project, String folderName, String newFolderName
     @LogMethod
     public void renameFolder(@LoggedParam String containerPath, @LoggedParam String newName, final boolean createAlias)
     {
-        Map<String, String> params = new HashMap<>();
-        params.put("name", URLEncoder.encode(newName, StandardCharsets.UTF_8));
-        params.put("addAlias", String.valueOf(createAlias));
-        params.put("titleSameAsName", String.valueOf(true));
+        Map<String, Object> params = new HashMap<>();
+        params.put("name", newName);
+        params.put("addAlias", createAlias);
+        params.put("titleSameAsName", true);
         SimpleHttpRequest simpleHttpRequest = new SimpleHttpRequest(WebTestHelper.buildURL("admin", containerPath, "renameFolder", params), "POST");
         simpleHttpRequest.copySession(_test.getDriver());
 

src/org/labkey/test/util/Crawler.java

@@ -1430,9 +1430,9 @@ String queryStringFromEntries(List<Map.Entry<String,String>> list)
         {
             if (!sb.isEmpty())
                 sb.append('&');
-            sb.append(URLEncoder.encode(e.getKey(), StandardCharsets.UTF_8));
+            sb.append(EscapeUtil.encode(e.getKey()));
             sb.append('=');
-            sb.append(null==e.getValue()?"":URLEncoder.encode(e.getValue(), StandardCharsets.UTF_8));
+            sb.append(EscapeUtil.encode(e.getValue()));
         }
         );
         return sb.toString();

src/org/labkey/test/util/EscapeUtil.java

@@ -78,7 +78,9 @@ static public String jsString(String s)
      */
     public static String encode(String s)
     {
-        return s == null ? "" : URLEncoder.encode(s, StandardCharsets.UTF_8);
+        return s == null ? "" : URLEncoder.encode(s, StandardCharsets.UTF_8)
+            // Product often doesn't decode '+' into ' '. "%20" is a more reliable encoding
+            .replace("+", "%20");
     }
 
     /**