Skip to content

Fix calculation of getRelativeTimeZoneOffset #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 3 commits into from
Feb 20, 2025
Merged

Fix calculation of getRelativeTimeZoneOffset #2288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
892c6fa
Fix calculation of getRelativeTimeZoneOffset
labkey-tchad Feb 19, 2025
dbe4e13
Merge remote-tracking branch 'origin/develop' into fb_timeZoneTestFixes
labkey-tchad Feb 20, 2025
510e51e
Merge remote-tracking branch 'origin/develop' into fb_timeZoneTestFixes
labkey-tchad Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/org/labkey/test/WebDriverWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,16 +217,17 @@ public int getWebDriverTimeZoneOffset()
}

/**
* Test process might be running in a different time zone from the browser. This allows shifting test date to
* browser dates.
* Test process might be running in a different time zone from the browser. This method give the number of minutes
* to add to a system date to convert to the equivalent browser date.
* <pre>{@code
* TestDateUtils.diffFromTodaysDate(Calendar.MINUTE, getRelativeTimeZoneOffset())
* }</pre>
* @return The number of minutes to add to a system date to convert to the equivalent browser date
* A negative value indicates that the browser's time zone is West of the system time zone. Positive is East.
* @return minute offset of browser's time zone relative to the system's
*/
public int getRelativeTimeZoneOffset()
{
return ZoneId.systemDefault().getRules().getOffset(Instant.now()).getTotalSeconds() / 60 - getWebDriverTimeZoneOffset();
return -(ZoneId.systemDefault().getRules().getOffset(Instant.now()).getTotalSeconds() / 60 + getWebDriverTimeZoneOffset());
}

/**
Expand Down