Ignore webtest.browser.tz property on Windows
#2335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
a team and
labkey-chrisj
and removed request for
a team
labkey-chrisj
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Before each test, the harness checks whether the browser in in the expected time zone. If it isn't, the harness starts a fresh browser.
Since the
TZenvironment variable doesn't work on Windows, the browser is never in the expected time zone when time zone shifting is configured.We should ignore the
webtest.browser.tzproperty on Windows until we can determine how to make it function there.Related Pull Requests
Changes
webtest.browser.tzproperty on Windows