-
Notifications
You must be signed in to change notification settings - Fork 9
Minor auto-refactor code cleanup on a massive scale #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
labkey-tchad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I fixed some incorrectly ordered arguments in lookup constructors and removed some unnecessary overrides to elementCache.
| String errorMsg = "\n*************** ERROR ***************" + | ||
| "\nFound a mismatch in the lists." + | ||
| "\nlist01(" + i + "): " + list01.get(i) + | ||
| "\nlist02(" + i + "): " + list02.get(i) + | ||
| "\n*************** ERROR ***************"; | ||
| log(errorMsg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a suggestion for a change, just a note.
This "style" of error recording was done before the checker() was implemented. This, and other code like this, should be replaced with calls to checker().
Rationale
We can cleanup tens of thousands of warnings across our codebase with IntelliJ's autorefactors. In some cases, this adopts newer, leaner syntax. In others, it simply removes code that's not serving any purpose.
Related Pull Requests
Changes