Refactor DataRegionTable to handle tricky characters better #2513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
approved these changes
Jun 26, 2025
Contributor
labkey-chrisj
left a comment
labkey-chrisj
left a comment
There was a problem hiding this comment.
Thanks for doing this!
labkey-danield
approved these changes
Jun 26, 2025
# Conflicts: # src/org/labkey/test/components/ui/grids/FieldReferenceManager.java
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
DataRegionTable doesn't actually handle field names with tricky characters. What it calls field names are actually fieldKeys. This update adopts a similar pattern to the recent app grid test update. I had to replicate some existing non-standard behavior to avoid breaking existing tests (removing spaces from fieldKeys and ignoring spaces when looking up field labels).
Related Pull Requests
Changes
DataRegionTableto useFieldReferenceManager.javato organize and identify columnsDataRegionTablemethods