Skip to content

Declare api and implementation dependencies to align with code usages #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 7 commits into from
Sep 22, 2020
Merged

Declare api and implementation dependencies to align with code usages #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87e94e5
Remove unused dependencies, add missing explicit dependencies and use…
labkey-susanh Aug 29, 2020
5772f5e
Restore some dependencies used outside testAutomation
labkey-susanh Aug 30, 2020
efaab22
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 7, 2020
3c7f948
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 12, 2020
e5661bc
better formatting for fun and profit
labkey-susanh Sep 17, 2020
905f278
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 17, 2020
b0ddcb6
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,50 @@ project.configurations {
}

project.dependencies {
api("junit:junit:${junitVersion}")
api("org.seleniumhq.selenium:selenium-api:${seleniumVersion}")
implementation("commons-io:commons-io:${commonsIoVersion}")
implementation("com.fasterxml.jackson.core:jackson-annotations:${jacksonAnnotationsVersion}")
implementation("org.bouncycastle:bcprov-jdk15on:${bouncycastleVersion}")

//api "org.seleniumhq.selenium:selenium-server:${seleniumVersion}"
implementation("org.seleniumhq.selenium:selenium-firefox-driver:${seleniumVersion}")
api("org.seleniumhq.selenium:selenium-support:${seleniumVersion}")
implementation("org.seleniumhq.selenium:selenium-remote-driver:${seleniumVersion}")
implementation("org.seleniumhq.selenium:selenium-chrome-driver:${seleniumVersion}")
implementation("org.seleniumhq.selenium:jetty-repacked:${jettyRepackagedVersion}")

api("org.apache.httpcomponents:httpcore:${httpcoreVersion}")
implementation("com.google.guava:guava:${guavaVersion}")
api("org.apache.httpcomponents:httpclient:${httpclientVersion}")
api("org.hamcrest:hamcrest-core:${hamcrestCoreVersion}")
implementation("org.apache.commons:commons-text:${commonsTextVersion}")
implementation("com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}")
implementation("org.apache.httpcomponents:httpmime:${httpmimeVersion}")
implementation("org.apache.commons:commons-collections4:${commonsCollections4Version}")
implementation("net.sf.opencsv:opencsv:${opencsvVersion}")
implementation("javax.servlet:javax.servlet-api:${servletApiVersion}") // originally 3.1.0
aspectj "org.aspectj:aspectjtools:${aspectjVersion}"
implementation "org.slf4j:slf4j-log4j12:${slf4jLog4j12Version}" // Suppresses unwanted logging from remoteapi and webdriver
implementation "com.github.lookfirst:sardine:${project.lookfirstSardineVersion}"
implementation "com.googlecode.json-simple:json-simple:${jsonSimpleVersion}"
implementation "javax.xml.bind:jaxb-api:${jaxbVersion}"
api "com.github.lookfirst:sardine:${project.lookfirstSardineVersion}"
api "com.googlecode.json-simple:json-simple:${jsonSimpleVersion}"
//implementation "javax.xml.bind:jaxb-api:${jaxbVersion}"
implementation "com.sun.xml.bind:jaxb-impl:${jaxbVersion}"
implementation "com.sun.xml.bind:jaxb-core:${jaxbVersion}"
implementation "commons-beanutils:commons-beanutils:${commonsBeanutilsVersion}"
api "commons-beanutils:commons-beanutils:${commonsBeanutilsVersion}"
implementation "org.apache.tika:tika-core:${tikaVersion}"
implementation "org.apache.commons:commons-compress:${commonsCompressVersion}"
implementation "org.apache.commons:commons-lang3:${commonsLang3Version}"
implementation "org.apache.commons:commons-math3:${commonsMath3Version}"
api "org.apache.commons:commons-lang3:${commonsLang3Version}"
implementation "org.apache.commons:commons-math3:${commonsMath3Version}" // used by test classes in targetedms
implementation "org.apache.pdfbox:pdfbox:${pdfboxVersion}"
implementation "org.apache.poi:poi:${poiVersion}"
api "org.apache.poi:poi:${poiVersion}"
implementation "org.apache.poi:poi-ooxml:${poiVersion}"
implementation "org.apache.xmlbeans:xmlbeans:${xmlbeansVersion}"
implementation "org.bouncycastle:bcpg-jdk15on:${bouncycastleVersion}"
implementation "org.jetbrains:annotations:${annotationsVersion}"
api "org.mock-server:mockserver-netty:${mockserverVersion}"
api "org.seleniumhq.selenium:selenium-server:${seleniumVersion}"
implementation "org.mock-server:mockserver-netty:${mockserverNettyVersion}" // used by test classes in accounts
runtimeOnly "org.aspectj:aspectjrt:${aspectjVersion}"
implementation "org.aspectj:aspectjtools:${aspectjVersion}"
api "org.aspectj:aspectjtools:${aspectjVersion}"
implementation "org.reflections:reflections:${reflectionsVersion}"
uiTestRuntimeOnly "org.aspectj:aspectjrt:${aspectjVersion}"

Expand Down
6 changes: 5 additions & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
aspectjVersion=1.9.6
commonsTextVersion=1.3
reflectionsVersion=0.9.10
hamcrestCoreVersion=1.3

lookfirstSardineVersion=5.7
jettyRepackagedVersion=9.4.12.v20180830
seleniumVersion=3.141.59
mockserverVersion=5.5.1
mockserverNettyVersion=5.5.1

labkeySchemasTestVersion=20.7.0