LSID value not found in table - throw exception to report error in the log and to the user #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Apr 22, 2022
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
A suggestion on simplifying the code but no additional review required
WNPRC_Purchasing/src/org/labkey/wnprc_purchasing/WNPRC_PurchasingManager.java
Outdated
Show resolved
Hide resolved
labkey-bpatel
added a commit
that referenced
this pull request
Aug 5, 2022
…e log and to the user (#180) * Remove unneeded catch block, and have method throw an exception to report errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Submitting a wnprc purchasing request form with extensible columns throws "java.lang.IllegalStateException: LSID value not found in table - purchasingRequests".
This error was not shown to the user nor was in labkey log to be able to debug (only place it was showing was in the browser debugger console)
Related Pull Requests
Changes