[pull] latest from npm:latest #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces extensive enhancements to the npm token management command, adding support for creating Granular Access Tokens (GATs) with fine-grained permissions. It updates the CLI interface, configuration, and documentation to allow users to specify token details such as name, description, expiration, package/scope/org restrictions, permission levels, and bypassing two-factor authentication. The changes also improve error messaging and ensure all new options are reflected in the config and docs. --------- Co-authored-by: Gar <gar+gh@danger.computer>
Fix a race condition in `withLock` where a slow `fs.stat` call could result in an ECOMPROMISED false positive. Due to the usage of `setInterval`, one callback could mutate `mtime` just before an overlapping callback's `fs.stat` promise has resolved, causing a mismatch. By switching to `setTimeout`, we ensure that we don't have overlapping callbacks and incorrect values. Additionally bump the stale threshold higher, to reduce the likelihood of another caller taking over a seemingly-stale-but-actually-active lock. Under Windows in particular, `fs.stat` [has been observed](#8710 (comment)) to sometimes take over 20 seconds, so we should err on the side of a higher threshold before we judge a lock as stale. The minor potential downside is that we might wait longer before taking over a stale lock, but lock takeover is already a very exceptional case (i.e. it would typically only happen if another process was SIGKILLed while holding the same lock) ## Testing Notes - Added a new test to cover this scenario - Verified [the failure](https://github.com/jenseng/cli/actions/runs/19373681768/job/55435674539) and [the fix](https://github.com/jenseng/cli/actions/runs/19373765497/job/55435952370) via one-off GHA workflow that does `npx --yes jest --version` ## References Fixes #8710
Owner
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (1) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 1 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )