arrow: support morsel driven parallelism for arrow tables#238
Merged
arrow: support morsel driven parallelism for arrow tables#238
Conversation
- Use ColumnarNodeTableSharedState::getNextBatch() for thread-safe batch assignment - Add initArrowScanForBatch() helper method to fetch batches from shared state - Modify initScanState() to initialize from shared state - Update scanInternal() to fetch next batch when current is exhausted Each parallel scan thread now gets assigned full RecordBatches via the shared state, enabling parallel processing across multiple batches.
a3e7548 to
f0ff5a8
Compare
- Add morsel tracking fields to ArrowNodeTableScanState (morselSize, start/end offsets) - Modify initArrowScanForBatch() to initialize morsel boundaries when assigning batches - Update scanInternal() to process only morsel-sized chunks (default: 2048 rows) - When morsels in a batch are exhausted, fetch next batch from shared state This enables parallel processing of large RecordBatches by dividing them into smaller morsels that can be processed by multiple threads concurrently.
f0ff5a8 to
e8f490d
Compare
Contributor
|
I would like propose some changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #183
Useful for multi-core machines.