Open
Conversation
…t only allows triplets, quadruplets, and quintuplets but works on Rakudo
Still primitive. Unfortunately it is also broken on Niecza right now.
Previously was implicitly relying on N: fields to create those, doh!
Lots of clean-up of this code in general, in specific this should now handle the case where the first measure of a tune is full length but has a repeat sign in the middle of it.
That is, we ignore the last all-space sections of a tune, which in turn means we don't generate \break \noPageBreak at the end of every tune.
Still lots of similar clean-ups that could be done!
These never helped with correct tunes, and in more recent versions of Lilypond, sometimes overrode the correct bar line marker (ie a repeat sign).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... in my version. Extensive use of ABC.parse with :rule instead of m/ <regex /.