Skip to content

Conversation

@tomaszantas
Copy link
Contributor

@tomaszantas tomaszantas commented Aug 13, 2024

Description

  1. Show uncategorized values in summary cards
  2. Show uncategorized in the tooltip on Profit and Loss chart
  3. don't sum up uncategorized to "Total" in detailed charts
  4. Add horizontal line chart in detailed charts
  5. Support negative expenses/revenue

⚠️ Important changes

Bottom banners in the Summary cards are by default disabled:

image

to enable them, use showUncategorized:

            <ProfitAndLoss.Summaries
                stringOverrides={stringOverrides?.profitAndLoss?.summaries}
                showUncategorized
              />


TransactionsToReviewCard supports now:

a) hideWhenNoTransactions - hide when no transactions to review (optional, disabled by default)
b) size - size large works better with new Summary cards - by default it's medium

<TransactionToReviewCard
            usePnlDateRange={true}
            onClick={onTransactionsToReviewClick}
            hideWhenNoTransactions
            size='large'
          />


PnL Detailed Charts have now Horizontal Line chart - by default disabled (showHorizontalChart = false):

image

To enable:

       <DetailedChart
          (...)
          showHorizontalChart
        />

How this has been tested?

image

image

image

@tomaszantas tomaszantas self-assigned this Aug 13, 2024
@tomaszantas tomaszantas force-pushed the feat/uncategorized-in-pnl-charts-summaries branch 2 times, most recently from 42c4cb3 to b9ab03a Compare August 23, 2024 10:54
@tomaszantas tomaszantas marked this pull request as ready for review August 23, 2024 11:33
@tomaszantas tomaszantas force-pushed the feat/uncategorized-in-pnl-charts-summaries branch from 3e051b2 to 20b18fa Compare September 5, 2024 08:40
@tomaszantas tomaszantas marked this pull request as draft November 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants