This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Updated testbox to delete old versions of the game, close running ins…#27
Open
MatthewFrench wants to merge 1 commit intoindevfrom
Open
Updated testbox to delete old versions of the game, close running ins…#27MatthewFrench wants to merge 1 commit intoindevfrom
MatthewFrench wants to merge 1 commit intoindevfrom
Conversation
…tances after 2 hours and catch crashing errors.
| console.log(`child process exited with code ${code}`); | ||
|
|
||
| try { | ||
| rmdir('../Game-Server-Repositories/'+serverName, function(error){ |
Member
There was a problem hiding this comment.
This might be directory traversal exploitable if serverName contains user input from anywhere. For example, if I call my server ../../../../ it could end up deleting a lot more than what you'd expect
Contributor
Author
There was a problem hiding this comment.
Line 90 in 26393ef
Server name is generated server side.
MythicManiac
approved these changes
Aug 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated testbox to delete old versions of the game, close running instances after 2 hours and catch crashing errors.