docs(security/azure): fix post-apply recipe (Consumption SKU)#184
docs(security/azure): fix post-apply recipe (Consumption SKU)#184cristim wants to merge 1 commit into
Conversation
The header comment in scheduled-tasks.tf told operators to inspect the deployed workflow with `az logicapp show`, but `az logicapp` targets Logic Apps Standard (`Microsoft.Web/sites` with `kind=workflowapp`). These workflows are Consumption-tier (`Microsoft.Logic/workflows` via `azurerm_logic_app_workflow`); running `az logicapp show -n <wf>` against one returns ResourceNotFound. Replace with `az resource show --resource-type Microsoft.Logic/workflows --api-version 2019-05-01`, which works against the right SKU and needs no cli extensions (`az logic workflow show` does, and that extension can fail to install on Python 3.12+ azure-cli builds). Comment-only — no resource, state, or runtime change. Refs #183.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change corrects Azure CLI command references in Terraform documentation comments for post-apply verification of Logic Apps Consumption tier deployments. The comments are updated to recommend Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Fixes the post-apply verification command in the security header comment of
scheduled-tasks.tf. The original comment (added in PR #74) told operators to useaz logicapp show, but that subcommand targets Logic Apps Standard (Microsoft.Web/siteswithkind=workflowapp); these workflows are Consumption-tier (Microsoft.Logic/workflowsviaazurerm_logic_app_workflow). Runningaz logicapp show -n <wf>against one returnsResourceNotFound.The replacement uses
az resource show --resource-type Microsoft.Logic/workflows --api-version 2019-05-01, which:azcli extension. (az logic workflow showdoes, and thelogicextension can fail to install on Python 3.12+ azure-cli builds — the standard install path on macOS Homebrew today, which is exactly when an operator would reach for the post-apply check.)Closes #183.
Scope
Comment-only — no resource, state, output, or runtime change.
terraform fmt -checkandterraform validateboth clean (the pre-commit hooks ran them).The two other surfaces called out in #183 (issue #50 "Steps to reproduce" and PR #74 "Test plan") are historical text — both will be addressed via corrective comments on those threads, not via code.
Test plan
terraform fmt -checkclean (pre-commitTerraform formatpassed).terraform validateclean (pre-commitTerraform validatepassed).Summary by CodeRabbit