Skip to content

fix(api): correct async self-invoke payload shape so collection actually runs #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
May 4, 2026
Merged

fix(api): correct async self-invoke payload shape so collection actually runs #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions internal/api/handler_recommendations_refresh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,27 @@ func (h *Handler) asyncInvokeSelf(ctx context.Context, functionARN string) error
return fmt.Errorf("failed to build Lambda client: %w", err)
}

// This payload matches the detectLambdaEventType "scheduled" branch in
// internal/server/lambda.go: `scheduledEvent.Action != ""` → "scheduled".
// HandleScheduledTask then dispatches to TaskCollectRecommendations.
payload, _ := json.Marshal(map[string]string{"event": "scheduled_recommendations"})
// Payload shape matches internal/server/handler.go::ScheduledEvent + its
// ParseScheduledEvent dispatch table: the Action field selects the
// scheduled-task type. "collect_recommendations" maps to
// TaskCollectRecommendations, which is what we want to fire.
//
// The previous payload `{"event":"scheduled_recommendations"}` had no
// matching field in ScheduledEvent at all — Action unmarshalled as ""
// and ParseScheduledEvent rejected the event with "unknown scheduled
// task action: \"\"". Verified in the deployed Lambda log
// `/aws/lambda/cudly-dev-426fc8af-api` request 3befb380-6d46-... — the
// async self-invoke was firing successfully but the receiving Lambda
// was rejecting every invocation, so collection never actually ran.
//
// Source = "aws.events" so detectLambdaEventType in
// internal/server/lambda.go (which checks Source == "aws.events" ||
// Action != "") classifies this consistently with EventBridge cron
// deliveries that already exercise this code path.
payload, _ := json.Marshal(map[string]string{
"source": "aws.events",
"action": "collect_recommendations",
})

_, err = invoker.Invoke(ctx, &lambda.InvokeInput{
FunctionName: aws.String(functionARN),
Expand Down