Skip to content

fix(email): unbreak factory_test.go after #333 merge glitch #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
May 11, 2026
Merged

fix(email): unbreak factory_test.go after #333 merge glitch #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/email/factory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,6 @@ func TestNewSenderFromEnvironment_EmailEnabled(t *testing.T) {
}

// Unset / empty → factory takes the default-enabled path.
t.Run("unset_falls_through", func(t *testing.T) {
orig, hadOrig := os.LookupEnv("EMAIL_ENABLED")
t.Cleanup(func() {
if hadOrig {
os.Setenv("EMAIL_ENABLED", orig)
} else {
os.Unsetenv("EMAIL_ENABLED")
}
t.Run("unset_falls_through", func(t *testing.T) {
prev, hadPrev := os.LookupEnv("EMAIL_ENABLED")
os.Unsetenv("EMAIL_ENABLED")
Expand All @@ -276,8 +268,6 @@ func TestNewSenderFromEnvironment_EmailEnabled(t *testing.T) {
aws(t)
ctx := context.Background()
sender, err := NewSenderFromEnvironment(ctx)
ctx := context.Background()
sender, err := NewSenderFromEnvironment(ctx)
require.NoError(t, err)
_, ok := sender.(*Sender)
assert.True(t, ok, "Expected AWS Sender when EMAIL_ENABLED is unset")
Expand Down