Store additional player project stats#371
Merged
heyheyjp merged 1 commit intofeatures/statsfrom Aug 5, 2016
Merged
Conversation
heyheyjp
force-pushed
the
features/player-stats
branch
from
0440230 to
5097b6d
Compare
| // Calculate ABC | ||
| const aggregateBuildCycles = (buildCycles || 1) * teamSize | ||
| function _findQuestionByType(questions, questionType) { | ||
| // see see https://github.com/LearnersGuild/game/issues/370 |
Contributor
There was a problem hiding this comment.
Yeah -- terrible, but at least it's isolated in one place.
Contributor
|
Minor questions more than feedback ... LGTM. |
Collaborator
Author
|
Good notes, @jeffreywescott, thanks. I'm going to integrate this feedback in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366.
Main Changes:
ls(learning support score)cc(culture contribution score)ec(expected contribution)ecd(expected contribution delta/diff)hours(hours worked)Other Changes:
surveyIdindex toresponsestable