Fix quickstart tutorial when running via pip install learnosity-sdk[quickstart]#80
Merged
Merged
Conversation
Contributor
Author
|
@walsh-conor this is my first PR after joining the company, so I could be missing something. If you have a moment to review I would appreciate it! 😄 Please review with caution though due to my new status! 😅 |
ferdia-sopermaccafraidh-lrn
force-pushed
the
fsmc-fix-quickstart
branch
from
fb4476e to
c0da22a
Compare
shtrom
reviewed
Aug 20, 2024
shtrom
reviewed
Aug 20, 2024
ferdia-sopermaccafraidh-lrn
force-pushed
the
fsmc-fix-quickstart
branch
from
c0da22a to
3308d91
Compare
ferdia-sopermaccafraidh-lrn
changed the title
docs.quickstart.assessment from namespace to normal package pip install learnosity-sdk[quickstart]
Converts assessment from a namespace to a normal module
ferdia-sopermaccafraidh-lrn
force-pushed
the
fsmc-fix-quickstart
branch
from
0d5c379 to
a1c86e2
Compare
This was referenced Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issue when running the quickstart guide when installinga as a library from the documentation.
Working now shown below locally in a fresh venv and install from the locally created wheels.
Checklist
Feature
Bug
Security
Documentation
ChangeLog.md updated
Tests added
All testsuites passed
make distcompleted successfully