Ail 162/feature/setup precommit basic linting#95
Merged
rodrigo-pessoa-lrn merged 4 commits intoNov 5, 2024
Conversation
3255434 to
1377e1d
Compare
Contributor
Author
|
Note for reviewers
All other files were modified according to the pre-commit hook rules (basically removal of trailing white spaces, additional of blank line at the bottom of every file and fixing typos in comments). These changes do not affect any logic or behaviour. |
3ad6bd6 to
35324c1
Compare
35324c1 to
2c03fbd
Compare
2c03fbd to
e45214c
Compare
b20de66 to
facfdb2
Compare
Contributor
ferdia-sopermaccafraidh-lrn
left a comment
There was a problem hiding this comment.
👏 praise: Looking good! Nice to no longer have whitespace issues 🚀
Some very minor comments and then ready to approve
michael-linnane-lrn
approved these changes
Nov 5, 2024
ferdia-sopermaccafraidh-lrn
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Add "easy win" pre-commit rules to help to catch simple errors and reduce whitespace differences in PRs as well.
PR Actions - What was done
How was this change tested
Notes:
N/A