Request for comments: use archinfo for generics#67
Open
erdnaxe wants to merge 2 commits intoLedger-Donjon:masterfrom
Open
Request for comments: use archinfo for generics#67erdnaxe wants to merge 2 commits intoLedger-Donjon:masterfrom
erdnaxe wants to merge 2 commits intoLedger-Donjon:masterfrom
Conversation
4e27746 to
9cada03
Compare
9cada03 to
92ca20b
Compare
92ca20b to
cce8892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rainbow already requires
archinfomodule for CLE. This module ships many information for most common architectures (including all Ghidra SLEIGH architectures) which could be reuse directly in Rainbow.This patch is an initial proposal to use
archinfoto lower the maintenance burden of Rainbow.