Skip to content

Proposal for #236 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kingofpayne wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Proposal for #236 #237

kingofpayne wants to merge 1 commit into from

Conversation

@kingofpayne
Copy link
Contributor

@kingofpayne kingofpayne commented Jul 30, 2021

No description provided.

niooss-ledger
niooss-ledger reviewed Jul 30, 2021
View reviewed changes
niooss-ledger
niooss-ledger reviewed Jul 30, 2021
View reviewed changes
@kingofpayne kingofpayne marked this pull request as draft July 30, 2021 13:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021 •
edited
Loading

Codecov Report

Merging #237 (2a732a5) into master (96875a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   55.59%   55.59%           
=======================================
  Files          67       67           
  Lines        6313     6313           
=======================================
  Hits         3510     3510           
  Misses       2803     2803

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96875a8...2a732a5. Read the comment docs.

@kingofpayne kingofpayne force-pushed the api-client-apdu-sw-improvement branch 4 times, most recently from 100e51c to d49b0cc Compare July 30, 2021 13:50
@kingofpayne kingofpayne force-pushed the api-client-apdu-sw-improvement branch from d49b0cc to 83e3e2d Compare July 30, 2021 14:35
@kingofpayne kingofpayne marked this pull request as ready for review July 30, 2021 15:04
@kingofpayne kingofpayne marked this pull request as draft July 30, 2021 15:11
@kingofpayne
Copy link
Contributor Author

kingofpayne commented Jul 30, 2021

There's still an issue with this change: status word checking is not performed if data method of ApduResponse is not called.

@lpascal-ledger lpascal-ledger changed the base branch from develop to master May 30, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niooss-ledger niooss-ledger niooss-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kingofpayne @codecov-commenter @niooss-ledger