Blacklist test instead of stopping if bench fails.#4
Open
Menkib64 wants to merge 1 commit intoLeelaChessZero:masterfrom
Open
Blacklist test instead of stopping if bench fails.#4Menkib64 wants to merge 1 commit intoLeelaChessZero:masterfrom
Menkib64 wants to merge 1 commit intoLeelaChessZero:masterfrom
Conversation
There is fairly common case that a worker has GPU problems. GPU problems will cause a bench failure. Reporting of bench failure stops the test. This is different to how compile errors are handled using client blacklist. This change makes bench error handle the same as compile errors.
There was a problem hiding this comment.
Pull request overview
Aligns benchmark-failure handling with compile/build-failure handling by blacklisting the workload on the client rather than stopping the entire test on the server.
Changes:
- Server:
client_bench_errorno longer marks the test as finished; it only logs the bench error event. - Client: on
OpenBenchBadBenchException, the worker now appends the currenttest.idtoconfig.blacklistbefore reporting the bench error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
OpenBench/views.py |
Removes server-side “stop test” behavior on bench error; keeps logging the event. |
Client/worker.py |
Adds the failing test id to the client blacklist on bench failure to avoid re-assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
john-sp
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is fairly common case that a worker has GPU problems. GPU problems will cause a bench failure. Reporting of bench failure stops the test. This is different to how compile errors are handled using client blacklist. This change makes bench error handle the same as compile errors.