Enable pro mode to allow all options#6
Enable pro mode to allow all options#6Menkib64 wants to merge 2 commits intoLeelaChessZero:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to introduce a new “pro” client variant by bumping the enforced client/server version to 36 and changing how engine binaries are named on disk.
Changes:
- Bump required client version from 35 → 36 in both server config and client worker.
- Change engine binary naming to include a
-pro-infix (e.g.,<engine>-pro-<sha8>).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Config/config.json | Updates the server-enforced client_version to 36. |
| Client/worker.py | Updates the client-reported CLIENT_VERSION to 36 to match the server requirement. |
| Client/utils.py | Changes the engine binary filename format to include -pro-. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def engine_binary_name(engine, commit_sha, net_path, private): | ||
| name = '%s-%s' % (engine, commit_sha.upper()[:8]) | ||
| name = '%s-pro-%s' % (engine, commit_sha.upper()[:8]) | ||
| if net_path and not private: | ||
| name += '-%s' % (net_path[-8:]) | ||
| return name |
There was a problem hiding this comment.
engine_binary_name() now unconditionally inserts -pro- into the engine binary filename. This changes the on-disk naming scheme for all engines, so existing cached binaries (built/downloaded under the previous <engine>-<sha> naming) will no longer be detected by check_for_engine_binary(), forcing rebuilds/re-downloads and potentially leaving duplicate/orphaned engine binaries. If the intent is to enable a new optional “pro mode”, consider making the -pro- suffix conditional (e.g., behind an explicit flag) and/or add backward-compatible lookup to reuse the old filename when present.
No description provided.