Skip to content

Feature/tasks#18

Merged
Leenday merged 8 commits intodevelopfrom
feature/tasks
Dec 22, 2022
Merged

Feature/tasks#18
Leenday merged 8 commits intodevelopfrom
feature/tasks

Conversation

@Leenday
Copy link
Copy Markdown
Owner

@Leenday Leenday commented Dec 17, 2022

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2022

Uffizzi Preview deployment-9249 was deleted.

end

def create
params['task']['author_id'] = current_user.id
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это зачем?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Без этого, не создаются таски из-за отсутствия айди автора:

image

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мы же передаем author_id

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб я что-то пропустил.
В логах при создании таски вот такие параметры:

web_1  | Started POST "/api/v1/tasks" for 172.30.0.1 at 2022-12-20 05:49:17 +0000
web_1  | Cannot render console from 172.30.0.1! Allowed networks: 127.0.0.0/127.255.255.255, ::1
web_1  | Processing by Api::V1::TasksController#create as JSON
web_1  |   Parameters: {"task"=>{"name"=>"fdas", "description"=>"asdf", "assignee_id"=>nil, "author_id"=>nil}}
web_1  |   User Load (0.5ms)  SELECT "users".* FROM "users" WHERE "users"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
web_1  |   ↳ app/controllers/concerns/auth_helper.rb:21:in `current_user'

В следующем блоке точно передаются, если из селекта выбрать автора, а в противном случае тоже nil.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

странно 🤔 ну ладно

Comment thread app/controllers/api/v1/tasks_controller.rb Outdated
Comment thread app/javascript/packs/components/TaskBoard/TaskBoard.js Outdated
Comment thread config/routes.rb Outdated
Comment thread package.json
Comment thread utils/fetchHelper.js
Comment thread utils/keysConverter.js
@Leenday
Copy link
Copy Markdown
Owner Author

Leenday commented Dec 19, 2022

Еще вопрос по билду:

Как можно ошибку победить? Точнее - в чем причина? Конфиг надо править?

curl: (22) The requested URL returned error: 500
Warning: Problem : HTTP error. Will retry in 1 seconds. 12 retries left.

@Leenday Leenday requested a review from greybutton December 19, 2022 17:56
@greybutton
Copy link
Copy Markdown

по ошибке 500, не понял когда она происходит

@Leenday
Copy link
Copy Markdown
Owner Author

Leenday commented Dec 20, 2022

по ошибке 500, не понял когда она происходит

Это по билдам при пуше ветки.
https://github.com/Leenday/task_manager/actions/runs/3731373066/jobs/6329598896

@Leenday Leenday mentioned this pull request Dec 20, 2022
Copy link
Copy Markdown

@greybutton greybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

насчет 500, у тебя уфизи файлы немного отличаются от примера, может из за этого не срабатывает уфизи деплой

end

def create
params['task']['author_id'] = current_user.id
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

странно 🤔 ну ладно

@Leenday Leenday merged commit 8f1e1c1 into develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants