Conversation
|
Uffizzi Preview |
greybutton
suggested changes
Dec 29, 2022
| def user_valid? | ||
| if user.blank? || !user.authenticate(password) | ||
| errors.add(:email, "email or password doesn't match") | ||
| Rollbar.error("email or password doesn't match") |
There was a problem hiding this comment.
роллбар не для логгирования валидаций
| # Without configuration, Rollbar is enabled in all environments. | ||
| # To disable in specific environments, set config.enabled=false. | ||
|
|
||
| config.access_token = Rails.application.credentials.dig(:rollbar, :access_token) |
There was a problem hiding this comment.
давай лучше через переменные окружения (environment variables) сделаем
Owner
Author
There was a problem hiding this comment.
А где правильно хранить переменные окружения в проекте?
.env, насколько я понимаю, не подходит.
There was a problem hiding this comment.
реальные в github secrets, для разработки в композе файле фейковую строчку задать
Leenday
force-pushed
the
feature/devops/rollbar
branch
from
ffaf29f to
29d454d
Compare
greybutton
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.