Bug: IssuesActor crashes with NoMethodError on `pattern` every tick

[kbb0118]

Summary

IssuesActor calls pattern 'github.issues.*' as a class-level DSL call, but it inherits from Legion::Extensions::Actors::Subscription which has no pattern method. This causes a NoMethodError on every tick cycle, spamming logs with:

Failed to build absorbers: undefined method 'pattern' for class Legion::Extensions::Github::Absorbers::IssuesActor

Root Cause

The pattern DSL belongs to Legion::Extensions::Absorbers::Base and takes two arguments: pattern(type, value). IssuesActor is an Actors::Subscription subclass and does not need a routing pattern declaration — its queue binding is handled by the subscription infrastructure. The pattern call was leftover from an earlier design and should be removed.

Impact

• NoMethodError logged on every tick
• GitHub issue absorber never registers with PatternMatcher
• Log noise makes real errors harder to spot

Fix

Remove the pattern 'github.issues.*' line from IssuesActor.

[Esity]

Good analysis. A few notes on the pattern DSL to give this full context:

The pattern DSL signature is pattern(type, value) — two arguments. Absorbers::Base registers patterns with a matcher type (:url, :file, etc.) plus a glob string. For example:

class Issues < Legion::Extensions::Absorbers::Base
  pattern :url, 'github.com/**/issues/*'
end

The call pattern 'github.issues.*' was wrong on two levels: wrong class (actor, not absorber) and wrong signature (one arg using an AMQP routing key format instead of type, glob).

On the "absorber never registers with PatternMatcher" impact: IssuesActor is a subscription actor and shouldn't register with PatternMatcher — that's correct by design. The actual Absorbers::Issues class handles GitHub issue absorption separately, and it's webhook/push-driven, so it may legitimately have no URL pattern (it receives pre-fetched payloads, it doesn't resolve URLs). That impact item in the summary is a bit misleading — removing the bad call from the actor doesn't prevent registration; the absorber class registers itself independently during boot via Builders::Absorbers.

The PR fix is correct and complete for what's described.