fix: add missing argument to function simulate_one_avatar#4
Open
hih0124 wants to merge 2 commits intoLehengTHU:masterfrom
Open
fix: add missing argument to function simulate_one_avatar#4hih0124 wants to merge 2 commits intoLehengTHU:masterfrom
hih0124 wants to merge 2 commits intoLehengTHU:masterfrom
Conversation
Owner
|
Thanks for your kind notification! Actually, this function was not adopted in our experiments. The function we used is "async_simulate_one_avatar", which enables us to run the simulation simultaneously in an async paradigm. However, I will check the errors you mentioned in the "simulate_one_avatar". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change
(missing argument & incorrect argument type)
Changes Made
current_pageargument to thereaction_to_recommended_itemsfunction.movies_on_pageparameter type from list to string in the "simulate_one_avatar" function.Testing