Redact password in Debug prints + some housekeeping #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoBorai
requested changes
Jan 22, 2026
Owner
LeoBorai
left a comment
LeoBorai
left a comment
There was a problem hiding this comment.
Hey @Iizuki thanks so much for openning this PR! Happy new year for you too!
- I would suggest moving CI/CD related changes to its own PR
- Adding a small check on the REDACTED text to be present so we make sure both:
- Password is not rendered
- The expected text its rendered
| # Make sure that there are no SemVer violations before publishing. | ||
| # https://github.com/obi1kenobi/cargo-semver-checks-action | ||
| - name: Check semver | ||
| uses: obi1kenobi/cargo-semver-checks-action@v2 |
Owner
There was a problem hiding this comment.
Hey @Iizuki do you think we could move this to a different PR?
| let debugged = format!("{credentials:?}"); | ||
| let pretty = format!("{credentials:#?}"); | ||
|
|
||
| assert!(!debugged.contains(password)); |
Owner
There was a problem hiding this comment.
Can we have a check for REDACTED?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, and happy 2026!
Here's the PR I promised before holidays.
Changes
Manual Debug impl
The main point of this PR. Replace the derived Debug implementation with a manual impl that redacts the password field.
Example output:
Misc housekeeping
Issue Refs
fixes: #12